Skip to content

Make doAnalyze more user-friendly #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make doAnalyze more user-friendly #44

wants to merge 3 commits into from

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 3, 2018

See the commit messages:

Remove location from metadata  …
The current location metadata is always null. The user may set an actual
location on the command line.

Split analysis from analysis reporting  …
This allows users of the library to call `doAnalyze` and work on the
results, rather than having to re-implement it.

Nicolas Mattia added 2 commits January 3, 2018 12:06
Remove location from metadata
ced9acf 
The current location metadata is always null. The user may set an actual
location on the command line.
Split analysis from analysis reporting
2756ec7 
This allows users of the library to call `doAnalyze` and work on the
results, rather than having to re-implement it.
@nmattia nmattia requested a review from mboes January 3, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nmattia